Skip to content

Replace pkg_resources and bump Python version requirements #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Replace pkg_resources and bump Python version requirements #203

wants to merge 8 commits into from
+19 −11

Conversation

@kafitzgerald
Copy link
Contributor

@kafitzgerald kafitzgerald commented Jul 28, 2025

Replaces the use of now deprecated pkg_resources.

Closes #200

@kafitzgerald kafitzgerald requested review from a team, brian-rose and dcamron and removed request for a team July 29, 2025 16:11
brian-rose
brian-rose approved these changes Aug 4, 2025
View reviewed changes
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that I understand everything that's going on here, but it's passing CI and I don't see anything amiss.

@dcamron
Copy link

dcamron commented Aug 4, 2025

importlib.resources.files was added in Python 3.9. I think that's a fine minimum Python to support moving forward, but we need to do more packaging cleanup before a release.

@kafitzgerald
Copy link
Contributor Author

kafitzgerald commented Aug 5, 2025

importlib.resources.files was added in Python 3.9. I think that's a fine minimum Python to support moving forward, but we need to do more packaging cleanup before a release.

Ah, right. And it looks like the Python versions on here are quite old at this point.

I'll put this in draft for now since it probably makes more sense to merge after those changes.

@kafitzgerald kafitzgerald marked this pull request as draft August 5, 2025 13:40
@kafitzgerald kafitzgerald marked this pull request as ready for review November 12, 2025 01:43
@kafitzgerald
Copy link
Contributor Author

kafitzgerald commented Nov 12, 2025

importlib.resources.files was added in Python 3.9. I think that's a fine minimum Python to support moving forward, but we need to do more packaging cleanup before a release.

@dcamron, I think the changes I just pushed should cover the key pieces here (i.e. Python versions and associated metadata) and a few minor things I caught along the way. Let me know if not.

I realize there's more that could be done re: packaging updates, but I think those can probably come later.

@kafitzgerald kafitzgerald changed the title Replace pkg_resources Replace pkg_resources and bump Python version requirements Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brian-rose brian-rose brian-rose approved these changes

@dcamron dcamron Awaiting requested review from dcamron dcamron was automatically assigned from ProjectPythia/infrastructure

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use of deprecated pkg_resources

3 participants

@kafitzgerald @dcamron @brian-rose